Ensure row actions display in first data column#189
Merged
Conversation
Previously, if a provider didn't define a specific column method for the first data column, the fallback column_default() was used without row actions. This left users unable to edit or delete ad codes for such providers. The fix adds automatic row action detection: when rendering via column_default(), we now check if the current column is the first data column (after 'cb' and 'id') and append the edit/delete links accordingly. Fixes #51 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_first_data_column()helper to detect the first data column (after checkbox and ID)column_default()Previously, if a provider didn't define a specific
column_{name}method for the first column, users couldn't edit or delete ad codes from that row.Test plan
composer test:integrationFixes #51
🤖 Generated with Claude Code